Discussion:
Small tinymail patch
Aniello Del Sorbo
2009-04-29 19:31:02 UTC
Permalink
Hi guys,

I was trying to build modest for Fremantle beta and I've encoutered an
issue while compiling tinymail.
I had to manually apply this patch in order to continue the compilation process.

[sbox-FREMANTLE_X86: ~/tinymail/libtinymail-camel/camel-lite] > svn diff
Index: camel/camel.c
===================================================================
--- camel/camel.c (revision 3910)
+++ camel/camel.c (working copy)
@@ -44,8 +44,10 @@
#include "camel-provider.h"
#include "camel-private.h"

+#ifdef HAVE_NSS
/* To protect NSS initialization and shutdown */
PRLock *nss_initlock = NULL;
+#endif /* HAVE_NSS */
/* Whether or not Camel has initialized the NSS library */
volatile gboolean nss_initialized = FALSE;


==================

I don't know, and haven't tried, if I can simply commit the change
myself or not.

--
anidel
Aniello Del Sorbo
2009-04-29 22:16:24 UTC
Permalink
Actually the patch is this one:

[sbox-FREMANTLE_X86: ~/tinymail/libtinymail-camel/camel-lite] > svn diff
Index: camel/camel.c
===================================================================
--- camel/camel.c (revision 3910)
+++ camel/camel.c (working copy)
@@ -44,10 +44,12 @@
#include "camel-provider.h"
#include "camel-private.h"

+#ifdef HAVE_NSS
/* To protect NSS initialization and shutdown */
PRLock *nss_initlock = NULL;
/* Whether or not Camel has initialized the NSS library */
volatile gboolean nss_initialized = FALSE;
+#endif /* HAVE_NSS */

static int initialized = FALSE;


I tried to commit, but I need authorization.
We'll look into the auth issue tomorrow.

--
anidel
Post by Aniello Del Sorbo
Hi guys,
I was trying to build modest for Fremantle beta and I've encoutered an
issue while compiling tinymail.
I had to manually apply this patch in order to continue the compilation process.
[sbox-FREMANTLE_X86: ~/tinymail/libtinymail-camel/camel-lite] > svn diff
Index: camel/camel.c
===================================================================
--- camel/camel.c       (revision 3910)
+++ camel/camel.c       (working copy)
@@ -44,8 +44,10 @@
 #include "camel-provider.h"
 #include "camel-private.h"
+#ifdef HAVE_NSS
 /* To protect NSS initialization and shutdown */
 PRLock *nss_initlock = NULL;
+#endif /* HAVE_NSS */
 /* Whether or not Camel has initialized the NSS library */
 volatile gboolean nss_initialized = FALSE;
==================
I don't know, and haven't tried, if I can simply commit the change
myself or not.
--
anidel
Sergio Villar Senin
2009-04-30 07:43:33 UTC
Permalink
Post by Aniello Del Sorbo
[sbox-FREMANTLE_X86: ~/tinymail/libtinymail-camel/camel-lite] > svn diff
Index: camel/camel.c
===================================================================
--- camel/camel.c (revision 3910)
+++ camel/camel.c (working copy)
@@ -44,10 +44,12 @@
#include "camel-provider.h"
#include "camel-private.h"
+#ifdef HAVE_NSS
/* To protect NSS initialization and shutdown */
PRLock *nss_initlock = NULL;
/* Whether or not Camel has initialized the NSS library */
volatile gboolean nss_initialized = FALSE;
+#endif /* HAVE_NSS */
static int initialized = FALSE;
I tried to commit, but I need authorization.
We'll look into the auth issue tomorrow.
--
anidel
Post by Aniello Del Sorbo
Hi guys,
I was trying to build modest for Fremantle beta and I've encoutered an
issue while compiling tinymail.
I had to manually apply this patch in order to continue the compilation process.
[sbox-FREMANTLE_X86: ~/tinymail/libtinymail-camel/camel-lite] > svn diff
Index: camel/camel.c
===================================================================
--- camel/camel.c (revision 3910)
+++ camel/camel.c (working copy)
@@ -44,8 +44,10 @@
#include "camel-provider.h"
#include "camel-private.h"
+#ifdef HAVE_NSS
/* To protect NSS initialization and shutdown */
PRLock *nss_initlock = NULL;
+#endif /* HAVE_NSS */
/* Whether or not Camel has initialized the NSS library */
volatile gboolean nss_initialized = FALSE;
==================
I don't know, and haven't tried, if I can simply commit the change
myself or not.
Thank you very much Aniello, but this is not the correct mailing list to
send the patch. Send it to tinymail-devel-list-***@public.gmane.org which is the
list devoted to the tinymail development and I'd approve it.

Br
Aniello Del Sorbo
2009-04-30 08:33:46 UTC
Permalink
Post by Sergio Villar Senin
Post by Aniello Del Sorbo
[sbox-FREMANTLE_X86: ~/tinymail/libtinymail-camel/camel-lite] > svn diff
Index: camel/camel.c
===================================================================
--- camel/camel.c     (revision 3910)
+++ camel/camel.c     (working copy)
@@ -44,10 +44,12 @@
 #include "camel-provider.h"
 #include "camel-private.h"
+#ifdef HAVE_NSS
 /* To protect NSS initialization and shutdown */
 PRLock *nss_initlock = NULL;
 /* Whether or not Camel has initialized the NSS library */
 volatile gboolean nss_initialized = FALSE;
+#endif /* HAVE_NSS */
 static int initialized = FALSE;
I tried to commit, but I need authorization.
We'll look into the auth issue tomorrow.
--
anidel
Post by Aniello Del Sorbo
Hi guys,
I was trying to build modest for Fremantle beta and I've encoutered an
issue while compiling tinymail.
I had to manually apply this patch in order to continue the compilation process.
[sbox-FREMANTLE_X86: ~/tinymail/libtinymail-camel/camel-lite] > svn diff
Index: camel/camel.c
===================================================================
--- camel/camel.c       (revision 3910)
+++ camel/camel.c       (working copy)
@@ -44,8 +44,10 @@
 #include "camel-provider.h"
 #include "camel-private.h"
+#ifdef HAVE_NSS
 /* To protect NSS initialization and shutdown */
 PRLock *nss_initlock = NULL;
+#endif /* HAVE_NSS */
 /* Whether or not Camel has initialized the NSS library */
 volatile gboolean nss_initialized = FALSE;
==================
I don't know, and haven't tried, if I can simply commit the change
myself or not.
Thank you very much Aniello, but this is not the correct mailing list to
list devoted to the tinymail development and I'd approve it.
Br
Sorry about that.

I'll subscribe later to it and send the patch there.
Thanks.

--
anidel

Loading...